Fix "field is never used" warning to take unions into account #36252
Conversation
Rather than saying "struct or union" or adding logic to determine the type of the item, just change the message to "field is never used", dropping the "struct". Update tests accordingly.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Maybe add a test containing a union with an unused field? |
|
@sanxiyn Done. |
|
@bors r+ |
|
📌 Commit 046c7f2 has been approved by |
|
⌛ Testing commit 046c7f2 with merge 2c846a7... |
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors: retry On Tue, Sep 6, 2016 at 7:46 AM, bors [email protected] wrote:
|
Fix "field is never used" warning to take unions into account When compiling code containing a union with an unused field, rustc says "struct field is never used". Rather than saying "struct or union", or adding logic to determine the type of the item, just change the message to "field is never used", dropping the "struct". Update tests accordingly.
When compiling code containing a union with an unused field, rustc says
"struct field is never used".
Rather than saying "struct or union", or adding logic to determine the
type of the item, just change the message to "field is never used",
dropping the "struct".
Update tests accordingly.