Skip to content

Conversation

yossi-k
Copy link
Contributor

@yossi-k yossi-k commented Aug 4, 2016

Fixes #35222. Part of #35233.
r? @GuillaumeGomez

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@killercup
Copy link
Member

By the way, if you include "Fixes #35222", GitHub will automatically close that issue once this PR is merged.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

Thanks for the PR! Looks good.

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 4, 2016

📌 Commit 7fc0b2f has been approved by jonathandturner

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

@bors rollup

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 4, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 4, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
bors added a commit that referenced this pull request Aug 5, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
bors added a commit that referenced this pull request Aug 5, 2016
@bors bors merged commit 7fc0b2f into rust-lang:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants