Automatically enable -Zorbit if -Zincremental is specified. #35159
Conversation
| DebuggingOptions { | ||
| orbit: true, | ||
| .. debugging_opts | ||
| } |
There was a problem hiding this comment.
This is a bit too much, could mutation be used instead?
There was a problem hiding this comment.
Though, I agree it would look better with mutation here.
There was a problem hiding this comment.
I was talking about code readability, not performance 😆.
There was a problem hiding this comment.
This is a bit too much, could mutation be used instead?
You think? I actually thought that it was more readable that way. The alternative would be to make debugging_opts mutable, but it's within a huge function.
Or would you prefer this:
let debugging_opts = if debugging_opts.incremental.is_some() &&
!debugging_opts.orbit {
early_warn(error_format, "Automatically enabling `-Z orbit` because \
`-Z incremental` was specified");
let mut debugging_opts = debugging_opts;
debugging_opts.orbit = true;
debugging_opts
}I really don't care that much one way or the other, just tell me which version you want :)
There was a problem hiding this comment.
I would've expected making debugging_opts mutable to be fine.
There was a problem hiding this comment.
OK, I'll change it.
|
r=me once updated |
michaelwoerister
force-pushed
the
incr-comp-implies-orbit
branch
from
c62a3ed to
f900b18
Compare
|
@bors r=nikomatsakis |
|
📌 Commit f900b18 has been approved by |
|
⌛ Testing commit f900b18 with merge 359fdda... |
|
💔 Test failed - auto-win-msvc-64-opt |
| // except according to those terms. | ||
|
|
||
| // ignore-pretty | ||
| // compile-flags:-Zincremental=tmp/cfail-tests/enable-orbit-for-incr-comp |
There was a problem hiding this comment.
You need -Zorbit=off now to test this.
michaelwoerister
force-pushed
the
incr-comp-implies-orbit
branch
from
f900b18 to
44dbc49
Compare
|
@bors r=nikomatsakis Set |
|
📌 Commit 44dbc49 has been approved by |
|
⌛ Testing commit 44dbc49 with merge f495483... |
…komatsakis Automatically enable -Zorbit if -Zincremental is specified. Fixes #34973 r? @nikomatsakis
Fixes #34973
r? @nikomatsakis