Skip to content

Warn or abort if -Zincremental is used without -Zorbit #34973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelwoerister opened this issue Jul 22, 2016 · 2 comments
Closed

Warn or abort if -Zincremental is used without -Zorbit #34973

michaelwoerister opened this issue Jul 22, 2016 · 2 comments
Labels
A-incr-comp Area: Incremental compilation
Milestone
Incremental compi...

Comments

@michaelwoerister
Copy link
Member

Because of #34151, incremental compilation cannot work reliably without MIR-trans. We should make sure that we can't run into this accidentally.

cc @nikomatsakis
@michaelwoerister michaelwoerister added the A-incr-comp Area: Incremental compilation label Jul 22, 2016
@michaelwoerister michaelwoerister added this to the Incremental compilation alpha milestone Jul 25, 2016
@michaelwoerister
Copy link
Member Author

I added this to the milestone, since it's easy to do and can only lead to trouble once people try out the alpha.

@nikomatsakis
Copy link
Contributor

Maybe we should just make -Z incremental imply -Z orbit? In any case, I just spent a bit of time debugging a case where I forgot to use -Z orbit =)

@michaelwoerister michaelwoerister mentioned this issue Aug 1, 2016
Merged
bors added a commit that referenced this issue Aug 3, 2016
@bors
Auto merge of #35159 - michaelwoerister:incr-comp-implies-orbit, r=ni…
f495483 
…komatsakis

Automatically enable -Zorbit if -Zincremental is specified.

Fixes #34973

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation
Projects
None yet
Milestone
Incremental compilation beta
Development

No branches or pull requests
2 participants
@nikomatsakis @michaelwoerister