Skip to content

Comment on the casts in the seek implementations on files #34916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2016
Merged

Comment on the casts in the seek implementations on files #34916

merged 1 commit into from
Aug 6, 2016

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Jul 19, 2016

No description provided.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 19, 2016

📌 Commit de24ae4 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Jul 20, 2016

⌛ Testing commit de24ae4 with merge 74d176d...

@bors
Copy link
Collaborator

bors commented Jul 20, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Jul 19, 2016 at 10:05 PM, bors [email protected] wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1835

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#34916 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Fwxco4CieYBCBNQ85GJUvS2-9PZks5qXayTgaJpZM4JPbD4
.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 20, 2016
Closed
@GuillaumeGomez
Copy link
Member

off64_t import isn't used anymore on android and made homu failed. I r- for the moment.

@bors: r-

@tbu- tbu- force-pushed the pr_comment_on_seek_cast branch from de24ae4 to 291b6f1 Compare August 5, 2016 18:18
@tbu-
Copy link
Contributor Author

tbu- commented Aug 5, 2016

Removed the off64_t import on Android.

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 5, 2016

📌 Commit 291b6f1 has been approved by GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 5, 2016
Rollup merge of rust-lang#34916 - tbu-:pr_comment_on_seek_cast, r=Gui…
e36be6e 
…llaumeGomez

Comment on the casts in the `seek` implementations on files
@sophiajt sophiajt mentioned this pull request Aug 5, 2016
Closed
bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35397 - jonathandturner:rollup, r=jonathandturner
43446fc 
Rollup of 18 pull requests

- Successful merges: #34916, #35287, #35288, #35331, #35353, #35356, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35394
- Failed merges: #35395
@eddyb eddyb mentioned this pull request Aug 6, 2016
Merged
eddyb added a commit to eddyb/rust that referenced this pull request Aug 6, 2016
@eddyb
Rollup merge of rust-lang#34916 - tbu-:pr_comment_on_seek_cast, r=Gui…
68f7b26 
…llaumeGomez

Comment on the casts in the `seek` implementations on files
bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35407 - eddyb:rollup, r=eddyb
444ff9f 
Rollup of 21 pull requests

- Successful merges: #33951, #34916, #35287, #35288, #35351, #35353, #35356, #35362, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35393, #35394
- Failed merges: #35331, #35395
@bors bors merged commit 291b6f1 into rust-lang:master Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tbu- @rust-highfive @steveklabnik @bors @alexcrichton @GuillaumeGomez