Skip to content

Bug/bool colors #34138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2016
Merged

Bug/bool colors #34138

merged 2 commits into from
Jun 7, 2016

Conversation

@hoodie
Copy link
Contributor

@hoodie hoodie commented Jun 7, 2016

This is actually #33661 @steveklabnik, sorry about this, github ate my homework

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 7, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

steveklabnik commented Jun 7, 2016

No worries. Looks good! @bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 7, 2016

📌 Commit 1d43497 has been approved by steveklabnik

@hoodie
Copy link
Contributor Author

hoodie commented Jun 7, 2016

I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch. I will never open a Pull Request from my master branch.... 😉

@steveklabnik steveklabnik mentioned this pull request Jun 7, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 7, 2016
@steveklabnik
Rollup merge of rust-lang#34138 - hoodie:bug/bool_colors, r=steveklabnik
a0bf3b8 
Bug/bool colors

This is actually rust-lang#33661 @steveklabnik, sorry about this, github ate my homework
bors added a commit that referenced this pull request Jun 7, 2016
@bors
Auto merge of #34139 - steveklabnik:rollup, r=steveklabnik
39a523b 
Rollup of 13 pull requests

- Successful merges: #33645, #33897, #33945, #34007, #34060, #34070, #34094, #34098, #34099, #34104, #34124, #34125, #34138
- Failed merges:
@bors bors merged commit 1d43497 into rust-lang:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoodie @rust-highfive @steveklabnik @bors