-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustdoc: display field types together with names in detailed docs #33377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @cmr (rust_highfive has picked a reviewer for you, use r? to override) |
I think I'm in favor. |
Can you show a screenshot of what this looks like? |
Nice but I'm afraid it's a bit too loaded. Hard choice... |
To render this nicely, I think the field name and type should be on its own line, with the documentation for it following indented a bit. |
(And I think the |
If no one beats me to it, I'll change this to implement @cmr's suggestions. |
I really don't like this design. :-/ Maybe with the "[-]" thing, it would work better at first. But I don't know how we could display the field's information nicely... |
Big 👍 for me! I always felt dumb having to scroll up to check field types. |
☔ The latest upstream changes (presumably #33965) made this pull request unmergeable. Please resolve the merge conflicts. |
Closing due to inactivity, but feel free to reopen with a rebase! |
Is this desirable? The problem I can see is that the type names might get quite long.
Fixes: #32024