Global error explanations improvements #31679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ I don't think we should be rewrapping the text in future PRs though. |
|
📌 Commit 1c87667 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 16, 2016
…on, r=Manishearth r? @Manishearth
|
@Manishearth: I did it only when I found something to change in the file. |
|
Most of this PR is rewrapped paragraphs with no other change. |
| determine the flow of execution. | ||
| determine the flow of execution. Erroneous code example: | ||
|
|
||
| ```compile_fail |
There was a problem hiding this comment.
@Manishearth: I added code examples in this file.
|
@Manishearth: So in conclusion, the rewrapping has only be done on diagnostics files which does have something else to change. |
|
@GuillaumeGomez yes, my point was, don't do that. There's no clear benefit of either rewrapping choice, and this just causes unnecessary churn to review and fill the history. |
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 17, 2016
…on, r=Manishearth r? @Manishearth
bors
added a commit
that referenced
this pull request
Feb 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth