rustbuild: Fix some parts with out of tree builds #31620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the ./configure step don't create any directories if rustbuild is enable as rustbuild will take care of everything.
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Be sure to put the git command into the right directory when we run the submodule management information. Closes rust-lang#31619
alexcrichton
force-pushed
the
fix-out-of-tree-builds
branch
from
dbc5521 to
5aef0e8
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 5aef0e8 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Feb 20, 2016
This removes creating some extraneous directories and also fixes some submodule management with out of tree builds. Closes #31619
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes creating some extraneous directories and also fixes some submodule management with out of tree builds.
Closes #31619