Rollup of 5 pull requests #31517
Closed
Rollup of 5 pull requests #31517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Feb 9, 2016
steveklabnik
commented
- Successful merges: Clean up Error Handling case study examples #31473, mod.rs: fix typo #31513, Minor spelling fixes #31514, Improve docs for Drain on String #31515, Properly document tuples #31516
- Failed merges:
Remove unnecessary cloning and conversions. Expand tabs left in examples.
"particularly" was misspelled.
This is the last bit of String docs needed to Close rust-lang#29376
…r=steveklabnik Remove unnecessary cloning and conversions. Expand tab characters left in code examples.
…excrichton "particularly" was misspelled. r? @steveklabnik
This is the last bit of String docs needed to Close rust-lang#29376
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit f8cae71 has been approved by |
|
⌛ Testing commit f8cae71 with merge fb85d9d... |
|
💔 Test failed - auto-mac-64-opt |
|
i am the worst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.