Skip to content

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Contributor

This is currently the style of the entire module. It would need to be consistently updated everywhere. I believe I chose this style because there are some examples which don't work with all of them, though I don't exactly remember.

@tshepang
Copy link
Member Author

I see my style used in the module looking after a quick check. What are you looking at?

@steveklabnik
Copy link
Contributor

The example directly below was what I double checked.

When I did these docs, I took a lot of pains to make them all consistent with each other generally. I'm not perfect though :)

@tshepang
Copy link
Member Author

The example below is just a copy. Nowhere else in the module did I see the style.

@steveklabnik
Copy link
Contributor

Okay, I double checked myself, because I swore I did it this way for all of them. It turns out that this set and IntoIterator do it this way, but all the others do it the way you've sent.

Would you mind updating the second block here to use this style, and IntoIterator? Then I'd be happy to merge.

Sorry about mis-remembering :(

@tshepang
Copy link
Member Author

tshepang commented Feb 1, 2016

Thanks for coming back to this issue

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 1, 2016

📌 Commit 4289973 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 1, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 2, 2016
bors added a commit that referenced this pull request Feb 2, 2016
@bors bors merged commit 4289973 into rust-lang:master Feb 2, 2016
@tshepang tshepang deleted the redundant-bindings branch February 2, 2016 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants