Remove emoji from docs #30390
Merged
Remove emoji from docs #30390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not think lack of fonts on anybody’s device is a justification good enough for removing/not-using features. On the other hand, emoji really do not belong in formal technical documentation. |
|
Considering this emoji is part of unicode 8 which was released only recently, that means a significant amount of devices don't support it. Even Firefox on Windows 10 doesn't support it. Having glyphs in the documentation which most devices are incapable of rendering is a poor idea. |
|
Seems like @bors missed the r+, ping @steveklabnik |
|
@bors: r+ rollup |
|
📌 Commit 6244314 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Dec 29, 2015
None of my devices/browsers renders this correctly. r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of my devices/browsers renders this correctly.
r? @steveklabnik