Apply debian changes to Make files #29955
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Debian wants to build all binaries with particular hardening flags. The Rust makefiles are inconsistent in which architectures they correctly include CFLAGS/etc from the enivoronment (see mk/cfg/*). This patch adds LDFLAGS, and then unconditionally prepends CFLAGS/LDFLAGS/etc to the build commands.
bltavares
force-pushed
the
makefile-29554
branch
from
a3501bd to
07b7f2f
Compare
|
@bors r+ Thanks! |
|
📌 Commit 07b7f2f has been approved by |
|
I've searched for more occurrences of the compiling and linking missing the flags but I was not able to find. I believe this will be all, but I would double check just to be safe (: |
Reference #29554