Skip to content

Compiler command line customization in the Rust makefile #29554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Nov 4, 2015 · 2 comments
Closed

Compiler command line customization in the Rust makefile #29554

brson opened this issue Nov 4, 2015 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Nov 4, 2015

Distros often have a standard, custom, set of flags that should be passed to all compiler invocations when building the binaries distributed as packages for that platform (think things like hardening options). For example, Debian wants to pass -Wl,-z,relro during the link step.

To support this, every compiler invocation in the makefile needs to include the appropriate CFLAGS, CXXFLAGS, LDFLAGS, or RUSTFLAGS variable. See the [Debian patch for guidance][debian-make].

re https://internals.rust-lang.org/t/perfecting-rust-packaging-the-plan/2767
@brson brson added the A-build label Nov 4, 2015
@bltavares bltavares mentioned this issue Nov 20, 2015
Merged
bors added a commit that referenced this issue Nov 23, 2015
@bors
Auto merge of #29955 - bltavares:makefile-29554, r=brson
a9d15a6 
Reference #29554
@brson
Copy link
Contributor Author

brson commented Dec 28, 2015

This is done. Thanks @bltavares .

@brson brson closed this as completed Dec 28, 2015
@bltavares
Copy link
Contributor

You are welcome (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bltavares @brson