Skip to content

Fix multiple mutable autoderefs with Box #28201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2015
Merged

Fix multiple mutable autoderefs with Box #28201

merged 1 commit into from
Sep 4, 2015

Conversation

apasel422
Copy link
Contributor

Closes #26205.

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Sep 3, 2015

@nikomatsakis Is the "leakage" of LvaluePreference okay here? I know you've expressed concerns in the past about that type.

@nikomatsakis
Copy link
Contributor

lemme take a look...

@nikomatsakis
Copy link
Contributor

Hmm. I don't love this flag, it's true, but this seems OK.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 4, 2015

📌 Commit b8dad48 has been approved by nikomatsakis

@apasel422
Copy link
Contributor Author

Presumably this flag will go away once Box is no longer special-cased.

@bors
Copy link
Collaborator

bors commented Sep 4, 2015

⌛ Testing commit b8dad48 with merge 2f77a59...

bors added a commit that referenced this pull request Sep 4, 2015
@bors bors merged commit b8dad48 into rust-lang:master Sep 4, 2015
@apasel422 apasel422 deleted the issue-26205 branch September 4, 2015 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants