Skip to content

Implement RFC 1058 #26966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2015
Merged

Implement RFC 1058 #26966

merged 1 commit into from
Jul 12, 2015

Conversation

@nagisa
Copy link
Member

@nagisa nagisa commented Jul 11, 2015

Fixes #26906

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 11, 2015

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa nagisa force-pushed the tail-init branch 6 times, most recently from cbfce11 to 8418fe9 Compare July 11, 2015 13:27
apasel422
apasel422 reviewed Jul 11, 2015
View reviewed changes
src/libcollections/slice.rs Outdated
Copy link
Contributor

@apasel422 apasel422 Jul 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/rest elements/rest of the elements/

Copy link
Member Author

@nagisa nagisa Jul 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

alexcrichton
alexcrichton reviewed Jul 11, 2015
View reviewed changes
src/libcollections/slice.rs Outdated
Copy link
Member

@alexcrichton alexcrichton Jul 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fairly significant change in terms of functionality so I don't think we should insta-stabilize these methods (e.g. leave them as #[unstable] for a little longer). Could you also give it a more descriptive feature name than "rfc1058"? Just to help error messages and such later on down the road.

Finally, could you leave the old tail methods and such, but #[deprecate] them in favor of these new methods?

@alexcrichton
Copy link
Member

alexcrichton commented Jul 11, 2015

Thanks @nagisa!

@nagisa nagisa force-pushed the tail-init branch 2 times, most recently from 9cff581 to db8d3cd Compare July 11, 2015 21:34
@nagisa
Copy link
Member Author

nagisa commented Jul 11, 2015

Comments addressed.

@alexcrichton
Copy link
Member

alexcrichton commented Jul 12, 2015

@bors: r+ 7a90865

Thanks!

bors added a commit that referenced this pull request Jul 12, 2015
@bors
Auto merge of #26966 - nagisa:tail-init, r=alexcrichton
50d305e 
Fixes #26906
@bors
Copy link
Collaborator

bors commented Jul 12, 2015

⌛ Testing commit 7a90865 with merge 50d305e...

@bors
Copy link
Collaborator

bors commented Jul 12, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 7a90865 into rust-lang:master Jul 12, 2015
@alexcrichton alexcrichton mentioned this pull request Aug 12, 2015
Closed
@tbu- tbu- mentioned this pull request Dec 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturon aturon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nagisa @rust-highfive @alexcrichton @bors @apasel422 @aturon