Skip to content

Expand documentation for the primitive type array #26923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2015

Conversation

bluss
Copy link
Member

@bluss bluss commented Jul 9, 2015

Expand documentation for the primitive type array

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 1abdd13 rollup

Thanks!

bors added a commit that referenced this pull request Jul 9, 2015
Expand documentation for the primitive type array
@bors
Copy link
Collaborator

bors commented Jul 9, 2015

⌛ Testing commit 1abdd13 with merge 67256df...

@@ -8,19 +8,48 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! The fixed-size array type (`[T; n]`).
//! A fixed-size array is denoted `[T; N]` for the element type `T` and
//! the compile time constant size `N`. The size should be zero or positive.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a 'must' rather than should, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it's not the reference, so it's not so technical I thought.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly, i mean we're not going all RFC 2119 or anything :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what RFC is that @steveklabnik

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently RFC 2119. I just had to google it to understand it's their text for defining what MUST, SHOULD etc mean in their standards :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thanks; and here I went looking at Rust RFC repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I meant IETF RFC :(

On Sat, Jul 11, 2015 at 3:11 PM, Tshepang Lekhonkhobe <
[email protected]> wrote:

In src/libstd/array.rs
#26923 (comment):

@@ -8,19 +8,48 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

-//! The fixed-size array type ([T; n]).
+//! A fixed-size array is denoted [T; N] for the element type T and
+//! the compile time constant size N. The size should be zero or positive.

oh, thanks; and here I went looking at Rust RFC repo


Reply to this email directly or view it on GitHub
https://github.com/rust-lang/rust/pull/26923/files#r34415454.

@steveklabnik
Copy link
Member

Thanks @bluss . I guess @bors is already working on this, so many we can address my comments in a new pr :)

@bors bors merged commit 1abdd13 into rust-lang:master Jul 10, 2015
@bluss bluss deleted the doc-array branch July 10, 2015 00:39
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2015
Small tweaks for the documentation of the primitive type array

Follow up to PR rust-lang#26923, fix a few small details.
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 11, 2015
Small tweaks for the documentation of the primitive type array

Follow up to PR rust-lang#26923, fix a few small details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants