Skip to content

Stdin::read_line: read_line does not need a mutable borrow #26897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2015
Merged

Stdin::read_line: read_line does not need a mutable borrow #26897

merged 1 commit into from
Jul 31, 2015

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 8, 2015

This fixes #26890.

To be honest, the local compile-test is still running. This just takes so long. But this looks trivial enough...

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton alexcrichton added I-needs-decision Issue: In need of a decision. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 8, 2015
@alexcrichton
Copy link
Member

Tagging with T-libs and I-needs-decision to ensure this comes up during triage

@RalfJung
Copy link
Member Author

RalfJung commented Jul 8, 2015

It locally compiles and passes libstd tests.

@RalfJung
Copy link
Member Author

Any news on this? Just trying to make sure this one doesn't get lost :)

@alexcrichton
Copy link
Member

@RalfJung yes sorry this past triage meeting was quite busy with agenda items, but I think we'll be able to get to this this week!

@alexcrichton
Copy link
Member

Ok we talked about this at the libs triage meeting today and the decision was to move forward with this, but to ensure we don't have unexpected breakage I'm going to run crater first.

@alexcrichton
Copy link
Member

This has zero regressions on crater, so I'm going to r+, thanks @RalfJung!

@bors: r+ 24f21f2

@bors
Copy link
Collaborator

bors commented Jul 31, 2015

⌛ Testing commit 24f21f2 with merge dc966ef...

bors added a commit that referenced this pull request Jul 31, 2015
This fixes #26890.

To be honest, the local compile-test is still running. This just takes so long. But this looks trivial enough...
@bors bors merged commit 24f21f2 into rust-lang:master Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-needs-decision Issue: In need of a decision. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stdin:read_line does not need &mut self
5 participants