-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Stdin::read_line: read_line does not need a mutable borrow #26897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Tagging with T-libs and I-needs-decision to ensure this comes up during triage |
It locally compiles and passes libstd tests. |
Any news on this? Just trying to make sure this one doesn't get lost :) |
@RalfJung yes sorry this past triage meeting was quite busy with agenda items, but I think we'll be able to get to this this week! |
Ok we talked about this at the libs triage meeting today and the decision was to move forward with this, but to ensure we don't have unexpected breakage I'm going to run crater first. |
This has zero regressions on crater, so I'm going to r+, thanks @RalfJung! |
This fixes #26890. To be honest, the local compile-test is still running. This just takes so long. But this looks trivial enough...
This fixes #26890.
To be honest, the local compile-test is still running. This just takes so long. But this looks trivial enough...