Skip to content

Corrected typo #25865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2015
Merged

Corrected typo #25865

merged 1 commit into from
May 30, 2015

Conversation

azerupi
Copy link
Contributor

@azerupi azerupi commented May 28, 2015

"workd" corrected to "world"

"workd" corrected to "world"
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@azerupi
Copy link
Contributor Author

azerupi commented May 28, 2015

Hi, quick question for the future. Is it considered best practice to add new commits to pending pull requests or create new pull request ? :)

@alexcrichton
Copy link
Member

@bors: r+ 15aeea5 rollup

Thanks! For small things like this feel free to tack them onto existing PRs, but more substantial changes should likely make their way into a new PR.

@azerupi
Copy link
Contributor Author

azerupi commented May 28, 2015

Nice, thank you!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 29, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 29, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 29, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 29, 2015
bors added a commit that referenced this pull request May 29, 2015
@bors bors merged commit 15aeea5 into rust-lang:master May 30, 2015
@azerupi azerupi deleted the patch-2 branch June 2, 2015 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants