Skip to content

Make it clear that push is only amortized O(1) #25714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2015
Merged

Make it clear that push is only amortized O(1) #25714

merged 1 commit into from
May 23, 2015

Conversation

brianquinlan
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@huonw
Copy link
Member

huonw commented May 22, 2015

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented May 22, 2015

📌 Commit 7389b0a has been approved by huonw

@Gankra
Copy link
Contributor

Gankra commented May 22, 2015

Our guarantee is, strictly speaking, a bit stronger than that: if you can accurately reserve a sufficient length, then it is O(1) worst-case. Ah well. 6 of one, half-a-dozen of the other.

oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 23, 2015
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 23, 2015
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 23, 2015
bors added a commit that referenced this pull request May 23, 2015
@bors bors merged commit 7389b0a into rust-lang:master May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants