syntax: Remove diagnostic validation temporarily #25592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the syntax diagnostic validation as it's been plauging the bots for two separate reasons and needs a quick fix for now: 1. It's possible to read the stale metadata of previous builds, causing spurious failures that can only be solved by blowing away `tmp`. 2. The code does not currently handle concurrent compilations where JSON files in the metadata directory may be half-written and hence contain invalid JSON when read. This validation should come back, but it should likely be part of a lint pass run at the very end of the build that doesn't run into consistency or concurrency problems.
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 7313a55 has been approved by |
|
Perhaps just remove the call to |
|
Concurrent writing to separate files is fine, we just have to get rid of the unsynchronised reads. Longer-term I agree that the uniqueness checking isn't particularly important, but it could be done in a Python script that runs once all the JSON files are generated (as you noted in the other thread, Alex). |
|
@michaelsproul I agree. I'll r- this and put up an alternative PR that keeps the generation and just removes the uniqueness checking. (Normally I'd let this land, but there are enough entries in the queue that I think I have time to come up with the alternative.) |
|
@bors r- |
pnkfelix
added a commit
to pnkfelix/rust
that referenced
this pull request
May 19, 2015
…guing the bots for two separate reasons and needs a quick fix for now: 1. It's possible to read the stale metadata of previous builds, causing spurious failures that can only be solved by blowing away `tmp`. 2. The code does not currently handle concurrent compilations where JSON files in the metadata directory may be half-written and hence contain invalid JSON when read. This validation should come back, but it should likely be part of a lint pass run at the very end of the build that doesn't run into consistency or concurrency problems. ---- This commit is a revised version of PR rust-lang#25592; this approach differs in that it continues to output the JSON metadata, so that the error index page continues to work (assuming that people do not accidentally put in duplicate entries in the meantime).
|
closing in favor of PR #25603 |
pnkfelix
added a commit
to pnkfelix/rust
that referenced
this pull request
May 21, 2015
…guing the bots for two separate reasons and needs a quick fix for now: 1. It's possible to read the stale metadata of previous builds, causing spurious failures that can only be solved by blowing away `tmp`. 2. The code does not currently handle concurrent compilations where JSON files in the metadata directory may be half-written and hence contain invalid JSON when read. This validation should come back, but it should likely be part of a lint pass run at the very end of the build that doesn't run into consistency or concurrency problems. ---- This commit is a revised version of PR rust-lang#25592; this approach differs in that it continues to output the JSON metadata, so that the error index page continues to work (assuming that people do not accidentally put in duplicate entries in the meantime).
This was referenced May 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the syntax diagnostic validation as it's been plauging the
bots for two separate reasons and needs a quick fix for now:
failures that can only be solved by blowing away
tmp.in the metadata directory may be half-written and hence contain invalid JSON
when read.
This validation should come back, but it should likely be part of a lint pass
run at the very end of the build that doesn't run into consistency or
concurrency problems.