Skip to content

Robust error explanation index and error code uniqueness checking #25705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pnkfelix opened this issue May 22, 2015 · 2 comments · Fixed by #26452
Closed

Robust error explanation index and error code uniqueness checking #25705

pnkfelix opened this issue May 22, 2015 · 2 comments · Fixed by #26452

Comments

@pnkfelix
Copy link
Member

The PR's #25380 #25592 #25603 were motivated by brittleness such as #25364.

But removing the diagnostics metadata output and checking represents a step backward, in that we no longer have an auto-generated error index (nor uniqueness checking).

This issue is a work-item to put those two features back.
pnkfelix added a commit to pnkfelix/rust that referenced this issue May 22, 2015
@pnkfelix
Remove error diagnostics uniqueness check and .json generation.
b4fc7cf 
This is meant to be a temporary measure to get the builds to be
reliable again; see also Issue rust-lang#25705.
@pnkfelix pnkfelix mentioned this issue May 22, 2015
Merged
pnkfelix added a commit to pnkfelix/rust that referenced this issue May 22, 2015
@pnkfelix
Remove error diagnostics uniqueness check and .json generation.
deaa117 
This is meant to be a temporary measure to get the builds to be
reliable again; see also Issue rust-lang#25705.
@mcast mcast mentioned this issue Jun 12, 2015
Closed
@mcast
Copy link
Contributor

mcast commented Jun 12, 2015

[...] we no longer have an auto-generated error index (nor uniqueness checking).
This issue is a work-item to put those two features back.

Are these two both covered by #26009 ?

It'd be nice to hang on to the error index in the Rust 1.2 release... currently it's disabled due to
[...]

  • In the error-index-generator - which runs once all crates have been compiled - we can check uniqueness.

(Via #26240)

@michaelsproul
Copy link
Contributor

Are these two both covered by #26009 ?

Yeah, this a "duplicate", but it's my fault, I created #26009 because I hadn't seen this.

@michaelsproul michaelsproul mentioned this issue Jun 20, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 20, 2015
@Manishearth
Rollup merge of rust-lang#26452 - michaelsproul:the-second-coming, r=…
7effb31 
…pnkfelix

As per rust-lang#26009 this PR implements a new collation system for extended-error metadata. I've tried to keep it as simple as possible for now, so there's no uniqueness checking and minimal modularity.

Although using a lint was discussed in rust-lang#26009 I decided against this because it would require converting the AST output from the plugin back into an internal data-structure. Emitting the metadata from within the plugin prevents this double-handling. We also didn't identify this as the source of the failures last time, although something untoward was definitely happening... With that in mind I would like as much feedback as possible on this before it's merged, I don't want to break the bots again!

I've successfully built for my host architecture and I'm building an ARM cross-compiler now to test my assumptions about the various `CFG` variables. Despite the confusing name of `CFG_COMPILER_HOST_TRIPLE` it is actually the compile time target triple, as explained in `mk/target.mk`.

```
# This is the compile-time target-triple for the compiler. For the compiler at
# runtime, this should be considered the host-triple. More explanation for why
# this exists can be found on issue rust-lang#2400
export CFG_COMPILER_HOST_TRIPLE
```

CC @pnkfelix @brson @nrc @alexcrichton 

Closes rust-lang#25705, closes rust-lang#26009.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resurrect the Compiler Error Index.
4 participants
@steveklabnik @mcast @pnkfelix @michaelsproul