Rollup of 10 pull requests #25315
Closed
Rollup of 10 pull requests #25315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
May 11, 2015
steveklabnik
commented
- Successful merges: fix for ICE issue #25180 #25209, [liballoc] Adds checks for UB during allocation. #25254, Add some long diagnostic messages. #25272, Fix grammar in path::Path documentation #25278, Remove extra parentheses #25282, Fix links in the referece #25283, Update BitSet docs with correct types #25288, TRPL: the stack and the heap #25292, Markdown formatting for error explanations. #25302, trpl: item macros must be followed by a semicolon #25304
- Failed merges:
… removed the with_mode copy, thanks to eddyb
They're only enabled in debug builds, but a panic is usually more welcome than UB in debug builds.
Change from "must be used with behind a pointer" to "must be used behind a pointer"
Update BitSet docs to correct type in one more spot removed accidental file
and remove references to the unit type, which no longer exists Fixes rust-lang#24999
According to @eddyb – and my tests – the following gets rid of the ICE in issue rust-lang#25180.
…Gankro They're only enabled in debug builds, but a panic is usually more welcome than UB in debug builds. Previous review at rust-lang#22069 r? @gankro cc @huon
Adds long diagnostic messages for: - E0184 - E0204 - E0205 - E0206 - E0243 - E0244 - E0249 - E0250 This PR also adds some comments to the error codes in `librustc_typeck/diagnostics.rs`. cc rust-lang#24407
Change from "must be used with behind a pointer" to "must be used behind a pointer"
…chton As mentioned in rust-lang#16676 (comment) this makes it a little bit more correct. I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.
and remove references to the unit type, which no longer exists Fixes rust-lang#24999
The functions BitSet::{iter,union,symmetric_difference} each had docs that claimed u32s were output when their actual output each end up being usizes.
r? @steveklabnik
…matsakis I think someday I'd like to make these drawings rather than text, but for now, this will have to be good enough.
…felix A few errors slipped through my filter. Markdown formatting is especially important now that http://doc.rust-lang.org/error-index.html is live! Speaking of, the error index should probably be linked to from somewhere. It doesn't quite fit under any of the sections in the index, but I could create a new one for it? Or add it under "tools" despite it not exactly being an executable tool.
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 4daaa06 has been approved by |
|
⌛ Testing commit 4daaa06 with merge 1227d5d... |
|
💔 Test failed - auto-mac-32-opt |
|
Strange, but I'm in vacation, so let's try again next Werk. |
|
Looking into it, it appears that I used print! In the tests, which triggered the error on pretty-printing. I'll change this to assert!s. |
|
Done the change. I'm still a bit puzzled why it failed, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.