std: Fixup docs for std::process #24960
Conversation
tynopex
commented
Apr 29, 2015
tynopex
commented
- Removed misleading comments about now-defunct CreatePipe
- Actually use std::process::Child in it's example
- Minor cleanups
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
| @@ -40,11 +40,15 @@ use thread; | |||
| /// ```should_panic | |||
| /// use std::process::Command; | |||
| /// | |||
| /// let output = Command::new("/bin/cat").arg("file.txt").output().unwrap_or_else(|e| { | |||
There was a problem hiding this comment.
I think this example was targeting the output() convenience method, so perhaps it could continue to use that instead of spawn()?
There was a problem hiding this comment.
The example is on http://doc.rust-lang.org/nightly/std/process/struct.Child.html but never used the Child type, so I changed to spawn which does.
Make whitespace consistent
- Removed misleading comments about now-defunct CreatePipe - Actually use std::process::Child in it's example - Minor cleanups
