Ignore some tests on aarch64 to pass the run-pass test on aarch64-linux-android #23471
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
cc @yichoi |
| ("xcore", "XCore"), | ||
| ("msp430", "MSP430"), | ||
| ("hexagon", "Hexagon"), | ||
| ("s390x", "SystemZ"), |
There was a problem hiding this comment.
Most of our ignore directives are all-lowercase, could these map to ignore-aarch64 for example?
|
Looks good to me! Just one minor nit and otherwise r=me |
|
@bors: r+ Thanks! |
|
📌 Commit 0ed265e has been approved by |
Resolved #21773. (Aarch64 test has been broken again) r? @alexcrichton
Unskip some tests on AArch64 I've been running the test suite remotely on an Acer Chromebook R13 and natively on an ARM Juno developer board, both AArch64 devices. Most of the tests that are skipped on AArch64 are due to testing stdcall/fastcall/x86-specific code or the debugger, but I've found a few tests that could be enabled there. These have been skipped previously due to failing on the `aarch64-linux-android` and `mac-android` buildbots, more than 2 years ago (#23471, #23695). It seems we don't test those platforms any more, but as they do work on AArch64 Linux, I'd like to propose re-enabling them. All of them pass on my devices.
Resolved #21773. (Aarch64 test has been broken again)
r? @alexcrichton