Skip to content

Skip default methods whose predicates are not satisfied when constructing vtables #23438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2015
Merged

Skip default methods whose predicates are not satisfied when constructing vtables #23438

merged 3 commits into from
Mar 18, 2015

Conversation

@nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Mar 17, 2015

Fixes #23435

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 17, 2015

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis nikomatsakis mentioned this pull request Mar 17, 2015
Merged
@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Mar 17, 2015

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned pcwalton Mar 17, 2015
nrc
nrc reviewed Mar 17, 2015
View reviewed changes
src/librustc_trans/trans/common.rs
Copy link
Member

@nrc nrc Mar 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain "freshens" in this comment please?

Copy link
Member

@nrc nrc Mar 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see it is explained further down

@nrc
Copy link
Member

nrc commented Mar 17, 2015

@bors: r+ bd2096c

(although I would be happier with a DRYer approach if it were possible)

@sfackler
Copy link
Member

sfackler commented Mar 17, 2015

@bors r=nrc bd2096c

@bors
Copy link
Collaborator

bors commented Mar 18, 2015

⌛ Testing commit bd2096c with merge 1ae32de...

bors added a commit that referenced this pull request Mar 18, 2015
@bors
Auto merge of #23438 - nikomatsakis:issue-23435-default-methods-with-…
1ae32de 
…where-clauses, r=nrc

Fixes #23435
@bors
Copy link
Collaborator

bors commented Mar 18, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit bd2096c into rust-lang:master Mar 18, 2015
@nikomatsakis nikomatsakis deleted the issue-23435-default-methods-with-where-clauses branch March 30, 2016 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrc nrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE when default method relies on where clauses that object type does not satisfy

6 participants

@nikomatsakis @rust-highfive @nrc @sfackler @bors @pcwalton