Skip to content

Ignore issue #16671 test on android (again) #22941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfackler wants to merge 2 commits into from
Closed

Ignore issue #16671 test on android (again) #22941

sfackler wants to merge 2 commits into from

Conversation

@sfackler
Copy link
Member

@sfackler sfackler commented Mar 1, 2015

Seems to be blocking forever

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 1, 2015

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler
Copy link
Member Author

sfackler commented Mar 1, 2015

@bors r+ 1f1c5d5 p=100

@Manishearth
Copy link
Member

Manishearth commented Mar 1, 2015

@bors: p=10

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2015
@Manishearth
Rollup merge of rust-lang#22941 - sfackler:re-disable, r=sfackler
c84e3a1 
 Seems to be blocking forever
@Manishearth
Copy link
Member

Manishearth commented Mar 1, 2015

(So as not to overshadow the rollup, which contains this PR anyway)

@Manishearth
Copy link
Member

Manishearth commented Mar 2, 2015

@bors: r+

@bors
Copy link
Collaborator

bors commented Mar 2, 2015

@bors r=Manishearth 5e19286

@bors
Copy link
Collaborator

bors commented Mar 2, 2015

⌛ Testing commit 5e19286 with merge a7467d2...

@bors
Copy link
Collaborator

bors commented Mar 2, 2015

💔 Test failed - auto-linux-64-x-android-t

@Manishearth
Copy link
Member

Manishearth commented Mar 2, 2015

@bors: retry

@bors
Copy link
Collaborator

bors commented Mar 2, 2015

⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

@bors
Copy link
Collaborator

bors commented Mar 2, 2015

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member

alexcrichton commented Mar 2, 2015

What's going on here? Do you have some example logs of what's going on?

Most of these failures just involve adding a call to .join() to fix as well.

@sfackler
Copy link
Member Author

sfackler commented Mar 2, 2015

The test just times out: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3858/steps/test/logs/stdio.

Do we have any idea why .join would actually fix things on android?

@alexcrichton
Copy link
Member

alexcrichton commented Mar 2, 2015

There are often unfortunate interactions with running concurrently with shutdown code. There is often an actual underlying issue but using .join for now should help in theory to "paper over it" (but an issue opened would still be nice!)

@Manishearth
Copy link
Member

Manishearth commented Mar 2, 2015

These both merged.

@emberian emberian closed this Mar 2, 2015
@sfackler sfackler deleted the re-disable branch November 26, 2016 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakis nikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sfackler @rust-highfive @Manishearth @bors @alexcrichton @nikomatsakis @emberian