Rollup of PRs in the queue; Monday #22940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traits can have associated types and not just methods. This clarification reflects the the type of the input the method accepts. [breaking-change]
Count recursion across phantom data separately from all recursion, and treat `Box<T>` just as if it were carrying `PhantomData<T>`. (Regression tests are in followup commit.) The practical effect of this is just to increment the `xref_depth` counter, the same way that `Vec` and other types carrying `PhantomData` do.
The logic for the argument translation was duplicated here.
this is the same problem as openbsd (rust-lang#22792). without the patch, liblibc don't build.
…ait objects For method calls through trait objects, we currently generate the llvm function argument attributes using the non-opaque method signature that still has the trait object fat pointer for the self pointer. This leads to attributes that are plain wrong, e.g. noalias. As we don't know anything about the concrete type of the underlying object, we must replace the self argument with an opaque i8 pointer before applying the attributes.
…e, r=Manishearth Part of rust-lang#22240.
Check for unbounded recursion during dropck. Such recursion can be introduced by the erroneous use of non-regular types (aka types employing polymorphic recursion), which Rust does not support. Fix rust-lang#22443
Traits can have associated types and not just methods. This clarification reflects the the type of the input the method accepts. [breaking-change]
The logic for the argument translation was duplicated here.
…hton this is the same problem as openbsd (rust-lang#22792). without the patch, liblibc don't build. @mneumann please comment. I have encountered this problem while building some rust libs with `target=x86_64-unknown-dragonfly` (while working on rust-lang#22794)
... objects For method calls through trait objects, we currently generate the llvm function argument attributes using the non-opaque method signature that still has the trait object fat pointer for the self pointer. This leads to attributes that are plain wrong, e.g. noalias. As we don't know anything about the concrete type of the underlying object, we must replace the self argument with an opaque i8 pointer before applying the attributes.
|
@bors: p=20 r+ |
Seems to be blocking forever
|
@bors: r+ |
Seems to be blocking forever
|
⌛ Testing commit c84e3a1 with merge 3161646... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
Been breaking tests lately. Somehow nondeterministic?
|
@bors: retry force |
|
@bors: r+ |
|
@bors: force |
|
⌛ Testing commit 6988157 with merge 4b3b02f... |
bors
added a commit
that referenced
this pull request
Mar 2, 2015
|
💔 Test failed - auto-linux-32-nopt-t |
|
@bors retry |
|
@bors: force |
|
⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-win-32-opt, auto-win-64-nopt-t... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.