Improve Rust Documentation & Reference on mobile #21133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tables that are too wide for the screen scroll horizontally. - Inline code that would force the page to become wider than the width of the screen is broken in the middle of the word.
|
I'm not sure what the preference is either, but this is a pretty strict improvement, so let's get it in. Thanks! :) |
bors
added a commit
that referenced
this pull request
Jan 14, 2015
Improve Rust Documentation & Reference on mobile Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 14, 2015
3 tasks
bors
referenced
this pull request
Jan 15, 2015
bors
added a commit
that referenced
this pull request
Jan 15, 2015
Improve Rust Documentation & Reference on mobile Reviewed-by: steveklabnik
bors
added a commit
that referenced
this pull request
Jan 15, 2015
Improve Rust Documentation & Reference on mobile Reviewed-by: steveklabnik
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 15, 2015
Just a couple of tweaks to improve the appearance of pages like [The Rust Reference](http://doc.rust-lang.org/reference.html) on mobile to advance the progress of rust-lang#20850. Changing the viewport wasn't quite good enough to make it mobile-friendly, as large tables forced the page to become wider than the screen width. Using `overflow-x`, tables that are too large become horizontally scrollable instead of forcing the *entire page* to become horizontally scrollable. Also, there was at least one case where an extremely long piece of inline code was wider than the actual width of the screen (`std::ptr::copy_nonoverlapping_memory`), so I changed `word-wrap` to allow inline code to break in the middle of words instead of only text within `pre` tags. This isn't a change included in this PR, but rather something up for discussion. Currently, code blocks that contain long lines simply wrap onto the next line. What if rather than wrapping, they were horizontally scrollable instead? I'm not sure what the general preference is regarding this. r? @steveklabnik
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of tweaks to improve the appearance of pages like The Rust Reference on mobile to advance the progress of #20850. Changing the viewport wasn't quite good enough to make it mobile-friendly, as large tables forced the page to become wider than the screen width. Using
overflow-x, tables that are too large become horizontally scrollable instead of forcing the entire page to become horizontally scrollable.Also, there was at least one case where an extremely long piece of inline code was wider than the actual width of the screen (
std::ptr::copy_nonoverlapping_memory), so I changedword-wrapto allow inline code to break in the middle of words instead of only text withinpretags.This isn't a change included in this PR, but rather something up for discussion. Currently, code blocks that contain long lines simply wrap onto the next line. What if rather than wrapping, they were horizontally scrollable instead? I'm not sure what the general preference is regarding this.
r? @steveklabnik