rustdoc: unmarked code fences are doctests too #20183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t("{.sh .should_fail}", true,false,false,true,false); | ||
| t("{.example .rust}", false,false,false,true,false); | ||
| t("{.test_harness .rust}", false,false,false,true,true); | ||
| // marker | should_fail | no_run | ignore | rust | test_harness |
There was a problem hiding this comment.
I had started a macro t! where you would do t!("sh", rust == false) and t!("", rust == true, no_run == false) or whatever. But the table at least makes things easier to see.
geomaster
added a commit
to geomaster/cargo
that referenced
this pull request
Dec 24, 2014
Two tests (test_with_deep_lib_dep and lib_with_standard_name) fail due to a bug in rustdoc (see rust-lang/rust#20183) so temporarily changing these so they pass. Be sure to change it back when the fix lands in the current rust nightly
|
So this is why my doctests have gone silent. Eagerly awaiting bors... |
bors
added a commit
that referenced
this pull request
Dec 26, 2014
#20075 introduced a bug where unmarked code fences weren't considered as doctests. This PR fixes the logic. --- This passed `check-stage1-rustdoc`, and I manually checked that: ``` rust //! ``` //! println!("Hello") //! ``` //! //! ``` rust //! println!("Hello") //! ``` //! //! ``` sh //! println!("Hello") //! ``` //! //! ``` ignore //! println!("Hello") //! ``` ``` Generated: ``` rust running 3 tests test _2 ... ignored test _0 ... ok test _1 ... ok ``` I'd love to add that as a test, but I have no idea how to do that with our testing infrastructure. If anyone knows how, do let me know! r? @alexcrichton @seanmonstar feedback?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20075 introduced a bug where unmarked code fences weren't considered as doctests. This PR fixes the logic.
This passed
check-stage1-rustdoc, and I manually checked that:Generated:
running 3 tests test _2 ... ignored test _0 ... ok test _1 ... okI'd love to add that as a test, but I have no idea how to do that with our testing infrastructure. If anyone knows how, do let me know!
r? @alexcrichton
@seanmonstar feedback?