Fully remove notrust markers from rustdoc
#20075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
🎊 |
|
I think that this technically actually isn't a breaking change because the marker "notrust" is now just like any other tag which indicates "this is not rust". Would you be ok removing the |
Internally refactor all mentions of `notrust` to the positive statement `rust`.
skade
force-pushed
the
remove-notrust
branch
from
c68c647 to
ee9de3b
Compare
|
@alexcrichton right. No logic after 24:00 for me ;). Removed. |
|
Thanks! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 22, 2014
Internally refactor all mentions of `notrust` to the positive statement `rust`. [breaking-change] Change remaining `notrust` markers to the thing they actually represent, e.g. `sh` or `plain`. This supersedes rust-lang#19693 .
bors
added a commit
that referenced
this pull request
Dec 26, 2014
#20075 introduced a bug where unmarked code fences weren't considered as doctests. This PR fixes the logic. --- This passed `check-stage1-rustdoc`, and I manually checked that: ``` rust //! ``` //! println!("Hello") //! ``` //! //! ``` rust //! println!("Hello") //! ``` //! //! ``` sh //! println!("Hello") //! ``` //! //! ``` ignore //! println!("Hello") //! ``` ``` Generated: ``` rust running 3 tests test _2 ... ignored test _0 ... ok test _1 ... ok ``` I'd love to add that as a test, but I have no idea how to do that with our testing infrastructure. If anyone knows how, do let me know! r? @alexcrichton @seanmonstar feedback?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally refactor all mentions of
notrustto thepositive statement
rust.[breaking-change] Change remaining
notrustmarkers tothe thing they actually represent, e.g.
shorplain.This supersedes #19693 .