Rollup #19785
Merged
Rollup #19785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line was declared twice, which causes the build of i10n docs to fail.
These should be properly annotated instead. Fixes rust-lang#16219.
Build `clean::ConstantItem` values in the `inline` module and pretty-print the AST for inlined const items. Doc strings are still missing from inlined constants (see rust-lang#19773). Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185 Fix rust-lang#15821
|
Running this through try first. |
|
Running through try again. |
Fix rust-lang#19773 Together with rust-lang#19774 (which this is rebased on): Fix rust-lang#18156, fix rust-lang#19722, fix rust-lang#19185
In preparation for removing the std::cmp::Ordering reexport, this needs
to be done to prevent errors like:
```
note: in expansion of #[deriving]
note: expansion site
error: unresolved name `std::cmp::Equal`
\#[deriving(Clone, PartialEq, PartialOrd, Eq, Ord, Show)]
^~~
```
|
Needs a rebase |
|
I guess I'll just close this and let bors do it. |
This line was declared twice, which causes the build of i10n docs to fail.
These should be properly annotated instead. Fixes rust-lang#16219.
This is a revival of rust-lang#19517 (per request of @alexcrichton) now that the new snapshots have landed. We can now remove the last feature gates for if_let, while_let, and tuple_indexing scattered throughout the test sources since these features have been added to Rust. Closes rust-lang#19473.
Build `clean::ConstantItem` values in the `inline` module and pretty-print the AST for inlined const items. Doc strings are still missing from inlined constants (see rust-lang#19773). Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185 Fix rust-lang#15821 r? @alexcrichton
The old PartialOrd impl for raw pointers would always return Some(_), so It might as well implement Ord too.
Vim still incorrectly highlights just `ExactSize` as a valid trait name, but the trait has been renamed to `ExactSizeIterator`.
On AArch64, libc::c_char is u8. There are some places in the code where i8 is assumed, which causes compilation errors. (AArch64 is not officially supported yet, but this change does not hurt any other targets and makes the code future-proof.)
Fix rust-lang#19773 Together with rust-lang#19774 (which this is rebased on): Fix rust-lang#18156, fix rust-lang#19722, fix rust-lang#19185 r? @alexcrichton (since this was your suggestion!)
In preparation for [removing the `std::cmp::Ordering` reexport](rust-lang#19253), this needs to be done to prevent errors like: ``` note: in expansion of #[deriving] note: expansion site error: unresolved name `std::cmp::Equal` #[deriving(Clone, PartialEq, PartialOrd, Eq, Ord, Show)] ^~~ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.