rustdoc: Properly inline const items #19774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build `clean::ConstantItem` values in the `inline` module and pretty-print the AST for inlined const items. Doc strings are still missing from inlined constants (see rust-lang#19773). Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185 Fix rust-lang#15821
tomjakubowski
force-pushed
the
rustdoc-consts-statics
branch
from
f7a1abc to
25223c8
Compare
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 12, 2014
Build `clean::ConstantItem` values in the `inline` module and pretty-print the AST for inlined const items. Doc strings are still missing from inlined constants (see rust-lang#19773). Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185 Fix rust-lang#15821 r? @alexcrichton
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 13, 2014
Build `clean::ConstantItem` values in the `inline` module and pretty-print the AST for inlined const items. Doc strings are still missing from inlined constants (see rust-lang#19773). Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185 Fix rust-lang#15821 r? @alexcrichton
tomjakubowski
added a commit
to tomjakubowski/rust
that referenced
this pull request
Dec 13, 2014
Fix rust-lang#19773 Together with rust-lang#19774 (which this is rebased on): Fix rust-lang#18156, fix rust-lang#19722, fix rust-lang#19185
bors
added a commit
that referenced
this pull request
Dec 14, 2014
rustdoc: Properly inline const items Reviewed-by: alexcrichton
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 15, 2014
Build `clean::ConstantItem` values in the `inline` module and pretty-print the AST for inlined const items. Doc strings are still missing from inlined constants (see rust-lang#19773). Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185 Fix rust-lang#15821 r? @alexcrichton
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 15, 2014
Fix rust-lang#19773 Together with rust-lang#19774 (which this is rebased on): Fix rust-lang#18156, fix rust-lang#19722, fix rust-lang#19185 r? @alexcrichton (since this was your suggestion!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
clean::ConstantItemvalues in theinlinemodule andpretty-print the AST for inlined const items.
Doc strings are still missing from inlined constants (see #19773).
Partially address #18156, #19722, #19185
Fix #15821
r? @alexcrichton