libsyntax: Forbid escapes in the inclusive range \x80-\xff in Unicode characters and strings.
#18504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hm, it looks like a merge went wrong here and a large number of things were introduced? |
|
@alexcrichton Actually, that was the result of regenerating the Unicode tables. They had to be regenerated in order to compile. |
| #[deprecated = "Replaced by String::from_utf16_lossy"] | ||
| pub fn from_utf16_lossy(v: &[u16]) -> String { | ||
| String::from_utf16_lossy(v) | ||
| } |
There was a problem hiding this comment.
I was referring to deprecations like these, they shouldn't have been introduced, right?
|
LGTM modulo the re-inclusion of a bunch of removed, previously-deprecated stuff that @alexcrichton pointed out. |
Unicode characters and strings. Use `\u0080`-`\u00ff` instead. ASCII/byte literals are unaffected. This PR introduces a new function, `escape_default`, into the ASCII module. This was necessary for the pretty printer to continue to function. RFC rust-lang#326. Closes rust-lang#18062. [breaking-change]
pcwalton
force-pushed
the
small-escapes
branch
from
ed31260 to
e8d6031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
\u0080-\u00ffinstead. ASCII/byte literals are unaffected.This PR introduces a new function,
escape_default, into the ASCIImodule. This was necessary for the pretty printer to continue to
function.
RFC #326.
Closes #18062.
[breaking-change]
r? @aturon