Preserve struct field pattern shorthand in the prettyprinter. #18362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `is_shorthand` field introduced by rust-lang#17813 (ead6c4b) to make the prettyprinter output the shorthand form. Fixes a few places that set `is_shorthand: true` when the pattern is not a PatIdent with the same name as the field.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 27, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Oct 29, 2024
feat: goto definition on range operators Closes rust-lang#18342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
is_shorthandfield introduced by #17813 (ead6c4b) to make the prettyprinter output the shorthand form. Fixes a few places that setis_shorthand: truewhen the pattern is not aPatIdentwith the same name as the field.This fixes incorrect
non_shorthand_field_patternswarnings when the shorthand is used in a quasiquote, e.g. in rust-peg.