Skip to content

Slicing renaming and feature gating #17807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 7, 2014
Merged

Slicing renaming and feature gating #17807

merged 5 commits into from
Oct 7, 2014

Conversation

nrc
Copy link
Member

@nrc nrc commented Oct 5, 2014

r? @aturon

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@nrc nrc changed the title Slice6 Slicing renaming and feature gating Oct 5, 2014
@nrc nrc mentioned this pull request Oct 6, 2014
Merged
aturon
aturon reviewed Oct 6, 2014
View reviewed changes
src/libcore/option.rs
@@ -846,21 +845,6 @@ impl<T: Default> Option<T> {
// Trait implementations
/////////////////////////////////////////////////////////////////////////////

impl<T> Slice<T> for Option<T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The as_slice method should remain, but as an inherent method.

@aturon
Copy link
Member

aturon commented Oct 6, 2014

Actually, given that we're not yet removing the AsSlice trait, you should just leave Option and Result as-is. If we eventually merge it with ops::Slice, we can consider what we want to do for these (e.g. move them to inherent methods if we want to avoid the slice notation).

r=me with the above.

@nrc
Copy link
Member Author

nrc commented Oct 7, 2014

High priority so it can get in the next release (cc @brson)

bors added a commit that referenced this pull request Oct 7, 2014
@bors
auto merge of #17807 : nick29581/rust/slice6, r=aturon
e62ef37 
r? @aturon
@bors bors closed this Oct 7, 2014
@bors bors merged commit eb2fdc8 into rust-lang:master Oct 7, 2014
@drbawb drbawb mentioned this pull request Oct 8, 2014
Merged
s-panferov added a commit to s-panferov/mime.rs that referenced this pull request Oct 9, 2014
@s-panferov
Rename Slice to AsSlice because of rust-lang/rust#17807
31014fa
@s-panferov s-panferov mentioned this pull request Oct 9, 2014
Merged
morr0ne pushed a commit to morr0ne/neo-mime that referenced this pull request Feb 22, 2025
@s-panferov @morr0ne
Rename Slice to AsSlice because of rust-lang/rust#17807
61889e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nrc @rust-highfive @aturon @alexcrichton @bors