libstd: Pass-through PATH in test_override_env #17667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizeman
force-pushed
the
fix-override-env
branch
from
fc30583 to
61e6482
Compare
In some build environments (such as chrooted Nix builds), `env` can only be found in the explicitly-provided PATH, not in default places such as /bin or /usr/bin. So we need to pass-through PATH when spawning the `env` sub-process. Fixes rust-lang#17617
wizeman
force-pushed
the
fix-override-env
branch
from
61e6482 to
5f4c280
Compare
bors
added a commit
that referenced
this pull request
Oct 1, 2014
In some build environments (such as chrooted Nix builds), `env` can only be found in the explicitly-provided PATH, not in default places such as /bin or /usr/bin. So we need to pass-through PATH when spawning the `env` sub-process. Fixes #17617
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
…kril Use rustup rust-analyzer component when there is a toolchain file override for the opened workspace Fixes rust-lang/rust-analyzer#17663
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
…kril Use rustup rust-analyzer component when there is a toolchain file override for the opened workspace Fixes rust-lang/rust-analyzer#17663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some build environments (such as chrooted Nix builds),
envcan onlybe found in the explicitly-provided PATH, not in default places such as
/bin or /usr/bin. So we need to pass-through PATH when spawning the
envsub-process.Fixes #17617