Move uses of enum to bitflags!. #17250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static X86StdcallCallConv = 64, | ||
| static X86FastcallCallConv = 65, | ||
| static X86_64_Win64 = 79, | ||
| } | ||
| } |
There was a problem hiding this comment.
Many of these don't seem to actually be bit flags per se, but rather just values in an enumeration. For example I don't think that this enumeration is actually a set of bitflags.
There are still others, but this is the first batch.
|
New patch. The only intended use of bitflags! is for Attributes. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 19, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
May 19, 2024
Correct Neovim 0.10 inlay hints config example This change is what I had to do to make inlay hints work on Neovim 0.10. The current example produces errors about wrong argument type to `.enable()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still others, but this is the first batch.