Restrict transmute intrinsicck to just rust-intrinsic fn's. #16751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,9 +73,13 @@ struct IntrinsicCheckingVisitor<'a> { | |||
|
|
|||
| impl<'a> IntrinsicCheckingVisitor<'a> { | |||
| fn def_id_is_transmute(&self, def_id: DefId) -> bool { | |||
| let intrinsic = match ty::get(ty::lookup_item_type(self.tcx, def_id).ty).sty { | |||
| ty::ty_bare_fn(ref bfty) => bfty.abi == RustIntrinsic, | |||
| _ => false | |||
There was a problem hiding this comment.
This could just return false quickly, right?
There was a problem hiding this comment.
Or rather, if this is not an intrinsic, it could return immediately to avoid the if-guards below.
|
r=me with just one small nit |
bors
added a commit
that referenced
this pull request
Aug 27, 2014
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2024
internal: Move diagnostics docs generation and lint definition generation into xtask/codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15562.