~ -> Box in the manual #16444
Merged
~ -> Box in the manual #16444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1535,7 +1535,7 @@ Likewise, supertrait methods may also be called on trait objects. | |||
| # impl Shape for int { fn area(&self) -> f64 { 0.0 } } | |||
| # impl Circle for int { fn radius(&self) -> f64 { 0.0 } } | |||
| # let mycircle = 0; | |||
| let mycircle: Circle = ~mycircle as ~Circle; | |||
| let mycircle = box mycircle; | |||
There was a problem hiding this comment.
I think this is trying to demonstrate something about trait objects? ("likewise supertrait methods may also be called on trait objects")
Maybe it could be let mycircle = box mycircle as Box<Circle>;?
There was a problem hiding this comment.
Ah. You are correct that the cast is needed to do the right thing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16439