-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make an example more clear with sample code. #15121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
May want to elaborate a bit more, I'm not 100% sure. |
After reading #11113, I will just comment that instead of the original sentence ("This excludes let from matching literals and most enum variants."), I would personally prefer a phrasing like "This excludes But I don't mind using an example in addition. :) |
(Or even just "This excludes |
I think you'll need an |
@alexcrichton I thought so too, but I thought I compiled and it worked. Which seemed bad. |
Just as an example:
|
Weird. @alexcrichton , does |
|
Okay, I've added the ignore, and also added the extra few words @pnkfelix suggested. When I ran |
r=me with a squash |
Squashed. |
Fixes #11113.