Update cargo submodule #149934

weihanglo · 2025-12-12T22:52:14Z

29 commits in 2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac..e91b2baa632c0c7e84216c91ecfe107c37d887c1
2025-12-04 16:47:28 +0000 to 2025-12-13 16:29:21 +0000

refactor(lints): move from cargo::util::lints to cargo::lints (refactor(lints): move from cargo::util::lints to cargo::lints cargo#16392)
test(lint): redact more due to line got omitted (test(lint): redact more due to line got omitted cargo#16391)
feat(report): cargo report timings HTML replay (feat(report): cargo report timings HTML replay cargo#16377)
feat: stabilize -Zconfig-include (feat: stabilize -Zconfig-include cargo#16284)
fix(package): Don't verify registry for --list (fix(package): Don't verify registry for --list cargo#16341)
Fixed incorrect locking logic when artifact-dir == build-dir (Fixed incorrect locking logic when artifact-dir == build-dir cargo#16385)
feat(log): make timing messages ready for HTML replay (feat(log): make timing messages ready for HTML replay cargo#16382)
chore(deps): update msrv (1 version) to v1.92 (chore(deps): update msrv (1 version) to v1.92 cargo#16381)
Downgrade curl-sys to 0.4.83 (Downgrade curl-sys to 0.4.83 cargo#16379)
fix(timing): more self-contained timing/log data (fix(timing): more self-contained timing/log data cargo#16378)
test: update to proc_macro::tracked::path (test: update to proc_macro::tracked::path cargo#16380)
refactor(lint): move lints to separate modules (refactor(lint): move lints to separate modules cargo#16364)
fix(index): Apply feedback from Cargo team (fix(index): Apply feedback from Cargo team cargo#16369)
fix(lints): handle lints separately at ws pkg level (fix(lints): handle lints separately at ws pkg level cargo#16367)
feat(lint): new implicit_minimum_version_req lint (feat(lint): new implicit_minimum_version_req lint cargo#16321)
fix(info): default to local without explicit reg (fix(info): default to local without explicit reg cargo#16358)
Remove [no-mentions] handler in our triagebot config (Remove [no-mentions] handler in our triagebot config cargo#16361)
Don't read the config file twice when $CARGO_HOME is a symlink (Don't read the config file twice when $CARGO_HOME is a symlink cargo#16325)
fix(timings): forgot to negate filter (fix(timings): forgot to negate filter cargo#16352)
fix(doctest): Include all search paths with new build layout (fix(doctest): Include all search paths with new build layout cargo#16348)
fix(layout): Remove hashes from bins in new layout (fix(layout): Remove hashes from bins in new layout cargo#16351)
docs(faq): Include an entry on disk space (docs(faq): Include an entry on disk space cargo#16349)
feat(timings): derive concurrency data from unit data (feat(timings): derive concurrency data from unit data cargo#16350)
perf(layout): Use unit_id, not pkg hash, for bin/lib pkg_dirs for new layout (perf(layout): Use unit_id, not pkg hash, for bin/lib pkg_dirs for new layout cargo#16345)
Validate target source paths before compilation with clearer errors (Validate target source paths before compilation with clearer errors cargo#16338)
test(doc): Remove unused build script (test(doc): Remove unused build script cargo#16344)
refactor(timings): store UnitData in RenderContext instead (refactor(timings): store UnitData in RenderContext instead cargo#16346)
perf(clean): Optimize (legacy) clean with multiple -p specifiers (perf(clean): Optimize (legacy) clean with multiple -p specifiers cargo#16264)
test: Adjust output for out-of-tree build-dir (test: Adjust output for out-of-tree build-dir cargo#16343)

rustbot · 2025-12-12T22:52:18Z

Some changes occurred in src/tools/cargo

cc @ehuss

rustbot · 2025-12-12T22:52:20Z

⚠️ Warning ⚠️

Some commits in this PR modify submodules.

If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

weihanglo · 2025-12-13T04:20:14Z

@bors r+ rollup=never p=1

bors · 2025-12-13T04:20:17Z

📌 Commit 3a26487 has been approved by weihanglo

It is now in the queue for this repository.

bors · 2025-12-13T05:56:11Z

⌛ Testing commit 3a26487 with merge 24608be...

Update cargo submodule 27 commits in 2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac..c46423de7351e3c4c734b2faa86088a9f5d1302b 2025-12-04 16:47:28 +0000 to 2025-12-12 23:16:12 +0000 - feat(report): cargo report timings HTML replay (rust-lang/cargo#16377) - feat: stabilize `-Zconfig-include` (rust-lang/cargo#16284) - fix(package): Don't verify registry for --list (rust-lang/cargo#16341) - Fixed incorrect locking logic when artifact-dir == build-dir (rust-lang/cargo#16385) - feat(log): make timing messages ready for HTML replay (rust-lang/cargo#16382) - chore(deps): update msrv (1 version) to v1.92 (rust-lang/cargo#16381) - Downgrade curl-sys to 0.4.83 (rust-lang/cargo#16379) - fix(timing): more self-contained timing/log data (rust-lang/cargo#16378) - test: update to `proc_macro::tracked::path` (rust-lang/cargo#16380) - refactor(lint): move lints to separate modules (rust-lang/cargo#16364) - fix(index): Apply feedback from Cargo team (rust-lang/cargo#16369) - fix(lints): handle lints separately at ws pkg level (rust-lang/cargo#16367) - feat(lint): new `implicit_minimum_version_req` lint (rust-lang/cargo#16321) - fix(info): default to local without explicit reg (rust-lang/cargo#16358) - Remove `[no-mentions]` handler in our triagebot config (rust-lang/cargo#16361) - Don't read the config file twice when $CARGO_HOME is a symlink (rust-lang/cargo#16325) - fix(timings): forgot to negate filter (rust-lang/cargo#16352) - fix(doctest): Include all search paths with new build layout (rust-lang/cargo#16348) - fix(layout): Remove hashes from bins in new layout (rust-lang/cargo#16351) - docs(faq): Include an entry on disk space (rust-lang/cargo#16349) - feat(timings): derive concurrency data from unit data (rust-lang/cargo#16350) - perf(layout): Use unit_id, not pkg hash, for bin/lib pkg_dirs for new layout (rust-lang/cargo#16345) - Validate target source paths before compilation with clearer errors (rust-lang/cargo#16338) - test(doc): Remove unused build script (rust-lang/cargo#16344) - refactor(timings): store UnitData in RenderContext instead (rust-lang/cargo#16346) - perf(clean): Optimize (legacy) clean with multiple -p specifiers (rust-lang/cargo#16264) - test: Adjust output for out-of-tree build-dir (rust-lang/cargo#16343)

bors · 2025-12-13T06:59:31Z

💔 Test failed - checks-actions

``` ---- expected: tests/testsuite/lints/implicit_minimum_version_req.rs:716:27 ++++ actual: stderr 1 1 | [WARNING] dependency version requirement without an explicit minimum version 2 2 | --> Cargo.toml:7:[..] 3 3 | | 4 - 7 | bar = { git = '[ROOTURL]/bar', version = "0.1" } 4 + 7 | ...known-linux-gnu/tmp/cit/t2182/bar', version = "0.1" } 5 5 | | [..]^^^^^ missing full version components 6 6 | | 7 7 | [HELP] consider specifying full `major.minor.patch` version components 8 8 | | 9 9 | 7 | bar = { git = '[ROOTURL]/bar', version = "0.1.0" } 10 10 | | [..]++ 11 11 | = [NOTE] `cargo::implicit_minimum_version_req` is set to `warn` in `[lints]` 12 12 | [UPDATING] git repository `[ROOTURL]/bar` 13 13 | [LOCKING] 1 package to latest compatible version 14 14 | [CHECKING] bar v0.1.0 ([ROOTURL]/bar#[..]) 15 15 | [CHECKING] foo v0.0.0 ([ROOT]/foo) 16 16 | [FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s ``` See rust-lang/rust#149934 (comment)

### What does this PR try to resolve? ``` ---- expected: tests/testsuite/lints/implicit_minimum_version_req.rs:716:27 ++++ actual: stderr 1 1 | [WARNING] dependency version requirement without an explicit minimum version 2 2 | --> Cargo.toml:7:[..] 3 3 | | 4 - 7 | bar = { git = '[ROOTURL]/bar', version = "0.1" } 4 + 7 | ...known-linux-gnu/tmp/cit/t2182/bar', version = "0.1" } 5 5 | | [..]^^^^^ missing full version components 6 6 | | 7 7 | [HELP] consider specifying full `major.minor.patch` version components 8 8 | | 9 9 | 7 | bar = { git = '[ROOTURL]/bar', version = "0.1.0" } 10 10 | | [..]++ 11 11 | = [NOTE] `cargo::implicit_minimum_version_req` is set to `warn` in `[lints]` 12 12 | [UPDATING] git repository `[ROOTURL]/bar` 13 13 | [LOCKING] 1 package to latest compatible version 14 14 | [CHECKING] bar v0.1.0 ([ROOTURL]/bar#[..]) 15 15 | [CHECKING] foo v0.0.0 ([ROOT]/foo) 16 16 | [FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s ``` See rust-lang/rust#149934 (comment) ### How to test and review this PR? r? Muscraft I wonder if annotate-snippets already has a way to control not omitting for tests (or that is not worthy).

weihanglo · 2025-12-13T17:35:52Z

@bors r+ rollup=never p=1

bors · 2025-12-13T17:35:55Z

📌 Commit 48b0f83 has been approved by weihanglo

It is now in the queue for this repository.

bors · 2025-12-13T18:20:56Z

⌛ Testing commit 48b0f83 with merge 430d829...

bors · 2025-12-13T21:34:47Z

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 430d829 to main...

github-actions · 2025-12-13T21:37:50Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8188f6c (parent) -> 430d829 (this PR)

Test differences

Show 83 test diffs

Stage 2

bad_config::directory_as_bench_target_path: [missing] -> pass (J0)
bad_config::directory_as_bench_target_path_with_entrypoint: [missing] -> pass (J0)
bad_config::directory_as_binary_target_path: [missing] -> pass (J0)
bad_config::directory_as_binary_target_path_with_entrypoint: [missing] -> pass (J0)
bad_config::directory_as_example_target_path: [missing] -> pass (J0)
bad_config::directory_as_example_target_path_with_entrypoint: [missing] -> pass (J0)
bad_config::directory_as_library_target_path: [missing] -> pass (J0)
bad_config::directory_as_library_target_path_with_entrypoint: [missing] -> pass (J0)
bad_config::directory_as_test_target_path: [missing] -> pass (J0)
bad_config::directory_as_test_target_path_with_entrypoint: [missing] -> pass (J0)
bad_config::nonexistent_bench_target_path: [missing] -> pass (J0)
bad_config::nonexistent_binary_target_path: [missing] -> pass (J0)
bad_config::nonexistent_example_target_path: [missing] -> pass (J0)
bad_config::nonexistent_library_target_path: [missing] -> pass (J0)
bad_config::nonexistent_test_target_path: [missing] -> pass (J0)
cargo_info::with_default_registry_configured::case: [missing] -> pass (J0)
cargo_info::with_default_registry_configured_and_specified::case: [missing] -> pass (J0)
cargo_report_timings::empty_log: [missing] -> pass (J0)
cargo_report_timings::gated_stable_channel: [missing] -> pass (J0)
cargo_report_timings::gated_unstable_options: [missing] -> pass (J0)
cargo_report_timings::help::case: [missing] -> pass (J0)
cargo_report_timings::html_snapshot::case: [missing] -> pass (J0)
cargo_report_timings::invalid_log: [missing] -> pass (J0)
cargo_report_timings::no_log: [missing] -> pass (J0)
cargo_report_timings::no_log_for_the_current_workspace: [missing] -> pass (J0)
cargo_report_timings::outside_workspace: [missing] -> pass (J0)
cargo_report_timings::prefer_latest: [missing] -> pass (J0)
cargo_report_timings::prefer_workspace: [missing] -> pass (J0)
cargo_report_timings::with_multiple_targets: [missing] -> pass (J0)
cargo_report_timings::with_section_timings: [missing] -> ignore (rustc --json=timings is unstable) (J0)
check::check_build_should_lock_target_dir_when_artifact_dir_is_same_as_build_dir: [missing] -> pass (J0)
check::check_build_should_not_lock_artifact_dir: pass -> [missing] (J0)
check::check_build_should_not_lock_artifact_dir_when_build_dir_is_not_same_dir: [missing] -> pass (J0)
config::config_symlink_home_duplicate_load: [missing] -> pass (J0)
config_include::enable_in_unstable_config: pass -> [missing] (J0)
config_include::gated: pass -> [missing] (J0)
config_include::mix_of_hierarchy_and_include_with_enable_in_unstable_config: pass -> [missing] (J0)
config_include::works_with_cli: pass -> [missing] (J0)
dep_info::no_trailing_separator_after_package_root_proc_macro: ignore (proc_macro::tracked_path is unstable) -> ignore (proc_macro::tracked::path is unstable) (J0)
generate_lockfile::publish_time_invalid: [missing] -> pass (J0)
lints::check_feature_gated_workspace_not_inherited: [missing] -> pass (J0)
lints::implicit_minimum_version_req::build_dep: [missing] -> pass (J0)
lints::implicit_minimum_version_req::deny: [missing] -> pass (J0)
lints::implicit_minimum_version_req::detailed_dep_major_only: [missing] -> pass (J0)
lints::implicit_minimum_version_req::dev_dep: [missing] -> pass (J0)
lints::implicit_minimum_version_req::exact_requirement_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::fully_specified_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::git_dep_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::git_dep_with_registry_version: [missing] -> pass (J0)
lints::implicit_minimum_version_req::greater_eq: [missing] -> pass (J0)
lints::implicit_minimum_version_req::greater_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::less_eq_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::less_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::major_minor: [missing] -> pass (J0)
lints::implicit_minimum_version_req::major_only: [missing] -> pass (J0)
lints::implicit_minimum_version_req::multiple_implicit_deps: [missing] -> pass (J0)
lints::implicit_minimum_version_req::multiple_requirements: [missing] -> pass (J0)
lints::implicit_minimum_version_req::path_dep_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::path_dep_with_registry_version: [missing] -> pass (J0)
lints::implicit_minimum_version_req::target_dep: [missing] -> pass (J0)
lints::implicit_minimum_version_req::target_dev_dep: [missing] -> pass (J0)
lints::implicit_minimum_version_req::tilde_requirement_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::unused_workspace_dep: [missing] -> pass (J0)
lints::implicit_minimum_version_req::unused_workspace_dep_and_package_implicit_req: [missing] -> pass (J0)
lints::implicit_minimum_version_req::wildcard_minor_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::wildcard_should_not_warn: [missing] -> pass (J0)
lints::implicit_minimum_version_req::workspace_inherited: [missing] -> pass (J0)
lints::tests::ensure_sorted_lint_groups: [missing] -> pass (J0)
lints::tests::ensure_sorted_lints: [missing] -> pass (J0)
lints::tests::ensure_updated_lint_groups: [missing] -> pass (J0)
lints::tests::ensure_updated_lints: [missing] -> pass (J0)
lints::unknown_lints::not_inherited: [missing] -> pass (J0)
test::doctest_dep: [missing] -> pass (J0)
test::doctest_dep_new_layout: [missing] -> pass (J0)
util::lints::tests::ensure_sorted_lint_groups: pass -> [missing] (J0)
util::lints::tests::ensure_sorted_lints: pass -> [missing] (J0)
util::lints::tests::ensure_updated_lint_groups: pass -> [missing] (J0)
util::lints::tests::ensure_updated_lints: pass -> [missing] (J0)
util::logger::tests::run_id_round_trip: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, x86_64-gnu-aux, x86_64-msvc-ext1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 430d8297c712ca7e8a4866d7ddccf1b71ba5d4d3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-rust-for-linux: 3265.0s -> 2766.1s (-15.3%)
x86_64-gnu-llvm-20: 2903.8s -> 2465.2s (-15.1%)
dist-aarch64-llvm-mingw: 6362.7s -> 5438.7s (-14.5%)
pr-check-1: 2008.5s -> 1728.5s (-13.9%)
dist-aarch64-msvc: 5570.5s -> 6239.6s (+12.0%)
dist-riscv64-linux: 4630.8s -> 5185.8s (+12.0%)
x86_64-gnu-gcc: 3477.7s -> 3073.7s (-11.6%)
x86_64-gnu-tools: 3707.4s -> 3303.2s (-10.9%)
tidy: 166.2s -> 148.4s (-10.7%)
dist-aarch64-apple: 6502.8s -> 5816.7s (-10.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-12-13T22:32:27Z

Finished benchmarking commit (430d829): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	17
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	22
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	17

Bootstrap: 472.396s -> 473.205s (0.17%)
Artifact size: 389.24 MiB -> 389.51 MiB (0.07%)

weihanglo self-assigned this Dec 12, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2025

weihanglo force-pushed the update-cargo branch from 4d017ab to 3a26487 Compare December 13, 2025 00:21

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2025

weihanglo mentioned this pull request Dec 13, 2025

test(lint): redact more due to line got omitted rust-lang/cargo#16391

Merged

Update cargo submodule

48b0f83

weihanglo force-pushed the update-cargo branch from 3a26487 to 48b0f83 Compare December 13, 2025 17:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 13, 2025

bors merged commit 430d829 into rust-lang:main Dec 13, 2025
12 checks passed

rustbot added this to the 1.94.0 milestone Dec 13, 2025

bors mentioned this pull request Dec 13, 2025

Crater run for cargo build-dir changes #149852

Open

Uh oh!

Update cargo submodule #149934

Update cargo submodule #149934

Conversation

weihanglo commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 12, 2025

Uh oh!

rustbot commented Dec 12, 2025

Uh oh!

weihanglo commented Dec 13, 2025

Uh oh!

bors commented Dec 13, 2025

Uh oh!

bors commented Dec 13, 2025

Uh oh!

This comment has been minimized.

bors commented Dec 13, 2025

Uh oh!

weihanglo commented Dec 13, 2025

Uh oh!

bors commented Dec 13, 2025

Uh oh!

bors commented Dec 13, 2025

Uh oh!

bors commented Dec 13, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 13, 2025

Test differences

Stage 2

Job duration changes

Uh oh!

rust-timer commented Dec 13, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

weihanglo commented Dec 12, 2025 •

edited

Loading