Skip to content

rustdoc: Fix broken link to Itertools::format #149578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 3, 2025
Merged

rustdoc: Fix broken link to Itertools::format #149578

bors merged 1 commit into from
Dec 3, 2025

Conversation

@lapla-cogito
Copy link
Contributor

@lapla-cogito lapla-cogito commented Dec 3, 2025 •
edited by rustbot
Loading

close #148879

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@notriddle
Copy link
Contributor

notriddle commented Dec 3, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 3, 2025

📌 Commit 8949b81 has been approved by notriddle

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 3, 2025

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2025
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Dec 3, 2025

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 3, 2025
Merged
bors added a commit that referenced this pull request Dec 3, 2025
@bors
Auto merge of #149581 - matthiaskrgr:rollup-w4dixyc, r=matthiaskrgr
254ed0a 
Rollup of 3 pull requests

Successful merges:

 - #148937 (Remove initialized-bytes tracking from `BorrowedBuf` and `BorrowedCursor`)
 - #149553 (added default_uwtables=true to aarch64_unknown_none targets)
 - #149578 (rustdoc: Fix broken link to `Itertools::format`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 3, 2025
@bors
Auto merge of #149581 - matthiaskrgr:rollup-w4dixyc, r=matthiaskrgr
8202d11 
Rollup of 3 pull requests

Successful merges:

 - #148937 (Remove initialized-bytes tracking from `BorrowedBuf` and `BorrowedCursor`)
 - #149553 (added default_uwtables=true to aarch64_unknown_none targets)
 - #149578 (rustdoc: Fix broken link to `Itertools::format`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7432e9e into rust-lang:main Dec 3, 2025
5 of 11 checks passed
rust-timer added a commit that referenced this pull request Dec 3, 2025
@rust-timer
Unrolled build for #149578
a9a3181 
Rollup merge of #149578 - lapla-cogito:rustdoc_iterformat, r=notriddle

rustdoc: Fix broken link to `Itertools::format`

close #148879
@rustbot rustbot added this to the 1.93.0 milestone Dec 3, 2025
@lapla-cogito lapla-cogito deleted the rustdoc_iterformat branch December 3, 2025 12:03
@lolbinarycat
Copy link
Contributor

lolbinarycat commented Dec 3, 2025

Is this an issue with the docs or is it a bug in rustdoc?

i was under the impression that it was a bug in rustdoc, it should be possible to have an intra-doc link using the []() form.

@lapla-cogito
Copy link
Contributor Author

lapla-cogito commented Dec 3, 2025

Based on my understanding, links to external crate's docs.rs should explicitly specify the target link e.g.

rust/src/librustdoc/passes/lint/unescaped_backticks.rs

Line 273 in 83e49b7

/// [tagged element]: https://docs.rs/pulldown-cmark/0.9/pulldown_cmark/enum.Tag.html

Therefore, I determined this is a bug in the documentation itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@notriddle notriddle

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

Broken link in rustdoc::display::Joined docs

6 participants

@lapla-cogito @rustbot @notriddle @bors @rust-log-analyzer @lolbinarycat