Skip to content

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Oct 31, 2025

The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library.

For rust-lang/miri#4648.

The dummy backend should be able to cross-compile to any target without
requiring any external tool or library other than the rust standard
library.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@mati865
Copy link
Member

mati865 commented Oct 31, 2025

@bors r? me

@rustbot rustbot assigned mati865 and unassigned JonathanBrouwer Oct 31, 2025
Copy link
Member

@mati865 mati865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, you could use the same code path as gnullvm/msvc—ask the backend to generate import libraries. But that would likely result in more code, so LGTM.

r=me if you are happy with this code

View changes since this review

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 31, 2025

That will indeed result in more code.

@bors r=mati865

@bors
Copy link
Collaborator

bors commented Oct 31, 2025

📌 Commit 23edbb6 has been approved by mati865

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
…=mati865

Don't require dlltool with the dummy backend on MinGW

The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library.

For rust-lang/miri#4648.
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
…=mati865

Don't require dlltool with the dummy backend on MinGW

The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library.

For rust-lang/miri#4648.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
…=mati865

Don't require dlltool with the dummy backend on MinGW

The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library.

For rust-lang/miri#4648.
bors added a commit that referenced this pull request Nov 1, 2025
Rollup of 10 pull requests

Successful merges:

 - #135602 (Tweak output of missing lifetime on associated type)
 - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`)
 - #142682 (Update bundled musl to 1.2.5)
 - #148171 (Simplify code to generate line numbers in highlight)
 - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`)
 - #148301 ([rustdoc search] Include extern crates when filtering on `import`)
 - #148330 (Don't require dlltool with the dummy backend on MinGW)
 - #148338 (cleanup: upstream dropped amx-transpose functionality)
 - #148340 (Clippy subtree update)
 - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 1, 2025
Rollup of 10 pull requests

Successful merges:

 - #135602 (Tweak output of missing lifetime on associated type)
 - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`)
 - #142682 (Update bundled musl to 1.2.5)
 - #148171 (Simplify code to generate line numbers in highlight)
 - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`)
 - #148301 ([rustdoc search] Include extern crates when filtering on `import`)
 - #148330 (Don't require dlltool with the dummy backend on MinGW)
 - #148338 (cleanup: upstream dropped amx-transpose functionality)
 - #148340 (Clippy subtree update)
 - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b79fc98 into rust-lang:master Nov 1, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 1, 2025
rust-timer added a commit that referenced this pull request Nov 1, 2025
Rollup merge of #148330 - bjorn3:dummy_backend_no_dlltool, r=mati865

Don't require dlltool with the dummy backend on MinGW

The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library.

For rust-lang/miri#4648.
@bjorn3 bjorn3 deleted the dummy_backend_no_dlltool branch November 1, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants