-
Notifications
You must be signed in to change notification settings - Fork 14k
Don't require dlltool with the dummy backend on MinGW #148330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library.
|
rustbot has assigned @JonathanBrouwer. Use |
|
@bors r? me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, you could use the same code path as gnullvm/msvc—ask the backend to generate import libraries. But that would likely result in more code, so LGTM.
r=me if you are happy with this code
|
That will indeed result in more code. @bors r=mati865 |
…=mati865 Don't require dlltool with the dummy backend on MinGW The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library. For rust-lang/miri#4648.
…=mati865 Don't require dlltool with the dummy backend on MinGW The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library. For rust-lang/miri#4648.
…=mati865 Don't require dlltool with the dummy backend on MinGW The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library. For rust-lang/miri#4648.
Rollup of 10 pull requests Successful merges: - #135602 (Tweak output of missing lifetime on associated type) - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`) - #142682 (Update bundled musl to 1.2.5) - #148171 (Simplify code to generate line numbers in highlight) - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`) - #148301 ([rustdoc search] Include extern crates when filtering on `import`) - #148330 (Don't require dlltool with the dummy backend on MinGW) - #148338 (cleanup: upstream dropped amx-transpose functionality) - #148340 (Clippy subtree update) - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 10 pull requests Successful merges: - #135602 (Tweak output of missing lifetime on associated type) - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`) - #142682 (Update bundled musl to 1.2.5) - #148171 (Simplify code to generate line numbers in highlight) - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`) - #148301 ([rustdoc search] Include extern crates when filtering on `import`) - #148330 (Don't require dlltool with the dummy backend on MinGW) - #148338 (cleanup: upstream dropped amx-transpose functionality) - #148340 (Clippy subtree update) - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #148330 - bjorn3:dummy_backend_no_dlltool, r=mati865 Don't require dlltool with the dummy backend on MinGW The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library. For rust-lang/miri#4648.
The dummy backend should be able to cross-compile to any target without requiring any external tool or library other than the rust standard library.
For rust-lang/miri#4648.