Fix many collections implementing PartialEq #14734
Conversation
They now properly check each element with the `eq` and `ne` methods in their own `eq` and `ne` method, respectively.
|
See also #14733. |
| } | ||
| fn ne(&self, other: &RingBuf<A>) -> bool { | ||
| !self.eq(other) | ||
| self.nelts != other.nelts && |
There was a problem hiding this comment.
And it should be any instead of all.
|
With #14733 this will only be needed for consistency. |
|
Would it be possible to add tests for this functionality? This seems very easy to get wrong during a refactoring. |
|
I don't think this is necessary now that we guarantee that == and != are inverses. |
|
@alexcrichton @sfackler |
|
Yes |
|
Closing due to inactivity, but feel free to reopen with a rebase! |
They now properly check each element with the
eqandnemethods in theirown
eqandnemethod, respectively.