[EXPERIMENT] Replace ResumeTy with an unsafe binder ty.

[cjgillot]

This actually is one of use cases unsafe binder types are meant to address. This PR tries to use them as so.

The implementation of unsafe binders is still incomplete, so this PR is mostly for experimentation and not meant to be merged.

r? @compiler-errors

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[rustbot]

compiler-errors is not on the review rotation at the moment.
They may take a while to respond.

[rust-log-analyzer]

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

diff of stderr:

5    |                      -- the expected `async` closure body
6 LL |
7 LL |     let () = x();
-    |         ^^   --- this expression has type `{static main::{closure#0}::{closure#0}<?15t> upvar_tys=?14t resume_ty=unsafe<Region(BrNamed(DefId(2:15634 ~ core[1112]::future::ResumeTy::'a))), Region(BrNamed(DefId(2:15635 ~ core[1112]::future::ResumeTy::'b)))> &'^0.Named(DefId(2:15634 ~ core[1112]::future::ResumeTy::'a)) mut Context<'^1.Named(DefId(2:15635 ~ core[1112]::future::ResumeTy::'b))> yield_ty=() return_ty=()}`
+    |         ^^   --- this expression has type `{static main::{closure#0}::{closure#0}<?15t> upvar_tys=?14t resume_ty=unsafe<Region(BrNamed(DefId(2:15675 ~ core[7629]::future::ResumeTy::'a))), Region(BrNamed(DefId(2:15676 ~ core[7629]::future::ResumeTy::'b)))> &'^0.Named(DefId(2:15675 ~ core[7629]::future::ResumeTy::'a)) mut Context<'^1.Named(DefId(2:15676 ~ core[7629]::future::ResumeTy::'b))> yield_ty=() return_ty=()}`
9    |         |
10    |         expected `async` closure body, found `()`
11    |

-    = note: expected `async` closure body `{static main::{closure#0}::{closure#0}<?15t> upvar_tys=?14t resume_ty=unsafe<Region(BrNamed(DefId(2:15634 ~ core[1112]::future::ResumeTy::'a))), Region(BrNamed(DefId(2:15635 ~ core[1112]::future::ResumeTy::'b)))> &'^0.Named(DefId(2:15634 ~ core[1112]::future::ResumeTy::'a)) mut Context<'^1.Named(DefId(2:15635 ~ core[1112]::future::ResumeTy::'b))> yield_ty=() return_ty=()}`
+    = note: expected `async` closure body `{static main::{closure#0}::{closure#0}<?15t> upvar_tys=?14t resume_ty=unsafe<Region(BrNamed(DefId(2:15675 ~ core[7629]::future::ResumeTy::'a))), Region(BrNamed(DefId(2:15676 ~ core[7629]::future::ResumeTy::'b)))> &'^0.Named(DefId(2:15675 ~ core[7629]::future::ResumeTy::'a)) mut Context<'^1.Named(DefId(2:15676 ~ core[7629]::future::ResumeTy::'b))> yield_ty=() return_ty=()}`
13                          found unit type `()`
14 
15 error: aborting due to 1 previous error


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args async-await/async-closures/def-path.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/async-await/async-closures/def-path.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/async-await/async-closures/def-path" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2021" "-Zverbose-internals"
stdout: none
--- stderr -------------------------------
error[E0308]: mismatched types
##[error]  --> /checkout/tests/ui/async-await/async-closures/def-path.rs:7:9
   |
LL |     let x = async || {};
   |                      -- the expected `async` closure body
LL |     //~^ NOTE the expected `async` closure body
LL |     let () = x();
   |         ^^   --- this expression has type `{static main::{closure#0}::{closure#0}<?15t> upvar_tys=?14t resume_ty=unsafe<Region(BrNamed(DefId(2:15675 ~ core[7629]::future::ResumeTy::'a))), Region(BrNamed(DefId(2:15676 ~ core[7629]::future::ResumeTy::'b)))> &'^0.Named(DefId(2:15675 ~ core[7629]::future::ResumeTy::'a)) mut Context<'^1.Named(DefId(2:15676 ~ core[7629]::future::ResumeTy::'b))> yield_ty=() return_ty=()}`
   |         |
   |         expected `async` closure body, found `()`
   |
   = note: expected `async` closure body `{static main::{closure#0}::{closure#0}<?15t> upvar_tys=?14t resume_ty=unsafe<Region(BrNamed(DefId(2:15675 ~ core[7629]::future::ResumeTy::'a))), Region(BrNamed(DefId(2:15676 ~ core[7629]::future::ResumeTy::'b)))> &'^0.Named(DefId(2:15675 ~ core[7629]::future::ResumeTy::'a)) mut Context<'^1.Named(DefId(2:15676 ~ core[7629]::future::ResumeTy::'b))> yield_ty=() return_ty=()}`
                         found unit type `()`

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0308`.

[compiler-errors]

Maybe let's crater this?

@bors try

[rust-bors]

💥 Test timed out after 21600s

[oli-obk]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 342ed2e (342ed2e8608ee307743c341962b427652cdb06e9, parent: d1ed52b1f5b78bf66127b670af813b84d57aeedb)

[oli-obk]

@craterbot check

[craterbot]

👌 Experiment pr-146562 created and queued.
🤖 Automatically detected try build 342ed2e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-146562 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-146562 is completed!
📊 2 regressed and 7 fixed (699587 total)
📊 1491 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-146562/retry-regressed-list.txt ↩

[bors]

☔ The latest upstream changes (presumably #146666) made this pull request unmergeable. Please resolve the merge conflicts.

[cjgillot]

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-146562/retry-regressed-list.txt

[craterbot]

👌 Experiment pr-146562-1 created and queued.
🤖 Automatically detected try build 342ed2e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-146562-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-146562-1 is completed!
📊 0 regressed and 0 fixed (1471 total)
📊 108 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-146562-1/retry-regressed-list.txt ↩