Skip to content

Conversation

rperier
Copy link
Contributor

@rperier rperier commented Sep 9, 2025

cc #141726

This is a proposal to unify and deduplicate the bits conv tests for f16, f32, f64 and f128

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rperier
Copy link
Contributor Author

rperier commented Sep 9, 2025

r? tgross35

@rustbot rustbot assigned tgross35 and unassigned Mark-Simulacrum Sep 9, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2025
@rperier rperier force-pushed the unify_and_dedup_bits_conv_float_tests branch from 669aa5c to b1c4e19 Compare September 10, 2025 12:26
@rperier
Copy link
Contributor Author

rperier commented Sep 10, 2025

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 10, 2025
@tgross35
Copy link
Contributor

LGTM, thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Sep 10, 2025

📌 Commit b1c4e19 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025
bors added a commit that referenced this pull request Sep 11, 2025
Rollup of 11 pull requests

Successful merges:

 - #142315 (core::ptr: deduplicate docs for as_ref, addr, and as_uninit_ref)
 - #146335 (disable core dumps for panic-uninitialized-zeroed)
 - #146347 (report duplicate symbols added by the driver)
 - #146370 (Update the LoongArch target documentation)
 - #146379 (Fix `compare_against_sw_vers` test)
 - #146380 (Unify and deduplicate bits conv float tests)
 - #146415 (s390x: mark soft-float target feature as incompatible)
 - #146422 (Less greedily parse `[const]` bounds)
 - #146424 (Improve `core::ops` coverage)
 - #146425 (Improve `core::array` coverage)
 - #146428 (Revert `assert!` desugaring changes (#122661))

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 11, 2025
Rollup of 11 pull requests

Successful merges:

 - #142315 (core::ptr: deduplicate docs for as_ref, addr, and as_uninit_ref)
 - #146335 (disable core dumps for panic-uninitialized-zeroed)
 - #146347 (report duplicate symbols added by the driver)
 - #146370 (Update the LoongArch target documentation)
 - #146379 (Fix `compare_against_sw_vers` test)
 - #146380 (Unify and deduplicate bits conv float tests)
 - #146415 (s390x: mark soft-float target feature as incompatible)
 - #146422 (Less greedily parse `[const]` bounds)
 - #146424 (Improve `core::ops` coverage)
 - #146425 (Improve `core::array` coverage)
 - #146428 (Revert `assert!` desugaring changes (#122661))

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c69a792 into rust-lang:master Sep 11, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 11, 2025
rust-timer added a commit that referenced this pull request Sep 11, 2025
Rollup merge of #146380 - rperier:unify_and_dedup_bits_conv_float_tests, r=tgross35

Unify and deduplicate bits conv float tests

cc #141726

This is a proposal to unify and deduplicate the bits conv tests for f16, f32, f64 and f128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants