fix comments about trait solver cycle heads #146373
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
?r @lcnr |
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Sep 9, 2025
| @@ -13,7 +13,7 @@ | |||
| //! behavior as long as the resulting behavior is still correct. | |||
| use std::cmp::Ordering; | |||
| use std::collections::hash_map::Entry; | |||
| use std::collections::{BTreeMap, btree_map}; | |||
| use std::collections::{btree_map, BTreeMap}; | |||
There was a problem hiding this comment.
incorrect formatting.
r=me after fixing it. Thanks for the PR
|
please squash commits :3 |
|
@bors delegate+ |
|
✌️ @calvinhirsch, you can now approve this pull request! If @lcnr told you to " |
calvinhirsch
force-pushed
the
trait-solver-cycle-head-docs
branch
from
e919501 to
7c20f9c
Compare
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 9, 2025
Rollup of 6 pull requests Successful merges: - #145463 (Reject invalid literal suffixes in tuple indexing, tuple struct indexing, and struct field name position) - #145929 (fix APITIT being treated as a normal generic parameter in suggestions) - #146001 (Update getopts to remove unicode-width dependency) - #146365 (triagebot: warn about #[rustc_intrinsic_const_stable_indirect]) - #146366 (add approx_delta to all gamma tests) - #146373 (fix comments about trait solver cycle heads) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 9, 2025
Rollup merge of #146373 - calvinhirsch:trait-solver-cycle-head-docs, r=lcnr fix comments about trait solver cycle heads update some comments that use "cycle root" rather than "cycle head" also fixed a random other nearby typo in `StackEntry` docs zulip thread: https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/quick.20question.20about.20SearchGraph.3A.3Aevaluate_goal_in_task/with/538004295 ?r lcnr
|
Bors, this has already been merged. @bors r- |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update some comments that use "cycle root" rather than "cycle head"
also fixed a random other nearby typo in
StackEntrydocszulip thread: https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/quick.20question.20about.20SearchGraph.3A.3Aevaluate_goal_in_task/with/538004295
?r lcnr