Skip to content

Conversation

@nikic
Copy link
Contributor

@nikic nikic commented Aug 26, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2025

⚠️ Warning ⚠️

@cuviper
Copy link
Member

cuviper commented Aug 26, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 26, 2025

📌 Commit 1d2cc80 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025
@bors
Copy link
Collaborator

bors commented Aug 28, 2025

⌛ Testing commit 1d2cc80 with merge b416342...

@bors
Copy link
Collaborator

bors commented Aug 28, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing b416342 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2025
@bors bors merged commit b416342 into rust-lang:master Aug 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 28, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 43a2166 (parent) -> b416342 (this PR)

Test differences

Show 3 test diffs

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b41634205b549a62cfa55363d1e00c4143d30033 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1405.0s -> 4006.5s (185.2%)
  2. dist-arm-linux-musl: 5527.8s -> 15163.8s (174.3%)
  3. dist-x86_64-solaris: 5162.9s -> 13588.2s (163.2%)
  4. dist-x86_64-illumos: 5831.6s -> 14738.4s (152.7%)
  5. dist-sparcv9-solaris: 5150.8s -> 12602.3s (144.7%)
  6. dist-ohos-armv7: 4033.3s -> 8974.0s (122.5%)
  7. test-various: 4829.0s -> 10016.1s (107.4%)
  8. dist-x86_64-freebsd: 4959.0s -> 10182.1s (105.3%)
  9. dist-ohos-x86_64: 4167.2s -> 8542.1s (105.0%)
  10. dist-aarch64-windows-gnullvm: 4666.6s -> 9521.7s (104.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b416342): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.6%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.6% [0.9%, 2.2%] 3
Regressions ❌
(secondary)
2.3% [0.8%, 3.4%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-3.8%, -0.8%] 2
All ❌✅ (primary) 1.6% [0.9%, 2.2%] 3

Cycles

Results (secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.1%] 38
Regressions ❌
(secondary)
0.0% [0.0%, 0.1%] 25
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.1%] 38

Bootstrap: 468.052s -> 468.353s (0.06%)
Artifact size: 390.65 MiB -> 390.65 MiB (0.00%)

makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants