Skip to content

Do not warn about missing change ID in tarball builds #145780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not warn about missing change ID in tarball builds #145780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/bootstrap/src/bin/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,16 @@ fn check_version(config: &Config) -> Option<String> {
Some(ChangeId::Id(id)) if id == latest_change_id => return None,
Some(ChangeId::Ignore) => return None,
Some(ChangeId::Id(id)) => id,
None => {
// The warning is only useful for development, not release tarballs
Copy link
Member

@Urgau Urgau Aug 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a pretty strong assertion, which I'm not sure distros agree with, at least Archlinux uses the change-id in their build, and they do update it for every new version.

Same for debian, config.toml.in.

Furthermore users can just put ignore if they don't want it.

None if !config.rust_info.is_from_tarball() => {
msg.push_str("WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations.\n");
msg.push_str("NOTE: to silence this warning, ");
msg.push_str(&format!(
"add `change-id = {latest_change_id}` or `change-id = \"ignore\"` at the top of `bootstrap.toml`"
));
return Some(msg);
}
None => return None,
};

// Always try to use `change-id` from .last-warned-change-id first. If it doesn't exist,
Expand Down
Loading